Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec(frontend): aboutページにリポジトリ・フィードバックのURLを表示させる #13271

Closed

Conversation

u1-liquid
Copy link
Contributor

What

Cherry-picked from MisskeyIO#441
Cherry-picked from MisskeyIO#438

Why

すでにmetaに存在するrepositoryUrlとfeedbackUrlを活用できるように

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (50817df) 64.38% compared to head (2ff5727) 65.77%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...kend/src/server/api/endpoints/admin/update-meta.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13271      +/-   ##
===========================================
+ Coverage    64.38%   65.77%   +1.39%     
===========================================
  Files          979      984       +5     
  Lines       109450   114085    +4635     
  Branches      5602     5653      +51     
===========================================
+ Hits         70469    75041    +4572     
- Misses       37549    37610      +61     
- Partials      1432     1434       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 12, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -11944,10 +11944,16 @@
                     ]
                   },
                   "repositoryUrl": {
-                    "type": "string"
+                    "type": [
+                      "string",
+                      "null"
+                    ]
                   },
                   "feedbackUrl": {
-                    "type": "string"
+                    "type": [
+                      "string",
+                      "null"
+                    ]
                   },
                   "impressumUrl": {
                     "type": [

Get diff files from Workflow Page

Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このPRでは実装しないことにした

locales/index.d.ts Outdated Show resolved Hide resolved
locales/ja-JP.yml Outdated Show resolved Hide resolved
@acid-chicken
Copy link
Member

私の方でコミットを引き継ぎます

@kakkokari-gtyih
Copy link
Contributor

#13285

@u1-liquid

This comment has been minimized.

@acid-chicken

This comment has been minimized.

@u1-liquid

This comment has been minimized.

@acid-chicken

This comment has been minimized.

@u1-liquid

This comment has been minimized.

@acid-chicken

This comment has been minimized.

@u1-liquid

This comment has been minimized.

@acid-chicken

This comment has been minimized.

@u1-liquid

This comment has been minimized.

@anatawa12

This comment has been minimized.

@tamaina

This comment has been minimized.

@u1-liquid

This comment has been minimized.

@u1-liquid

This comment has been minimized.

@tamaina

This comment has been minimized.

@u1-liquid u1-liquid closed this Feb 13, 2024
@u1-liquid u1-liquid deleted the about-repository-info branch February 13, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants