-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spec(frontend): aboutページにリポジトリ・フィードバックのURLを表示させる #13271
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #13271 +/- ##
===========================================
+ Coverage 64.38% 65.77% +1.39%
===========================================
Files 979 984 +5
Lines 109450 114085 +4635
Branches 5602 5653 +51
===========================================
+ Hits 70469 75041 +4572
- Misses 37549 37610 +61
- Partials 1432 1434 +2 ☔ View full report in Codecov by Sentry. |
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -11944,10 +11944,16 @@
]
},
"repositoryUrl": {
- "type": "string"
+ "type": [
+ "string",
+ "null"
+ ]
},
"feedbackUrl": {
- "type": "string"
+ "type": [
+ "string",
+ "null"
+ ]
},
"impressumUrl": {
"type": [ |
5c5744a
to
7674ad5
Compare
Cherry-picked from MisskeyIO#441 Cherry-picked from MisskeyIO#438
7674ad5
to
2532bca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
このPRでは実装しないことにした
私の方でコミットを引き継ぎます |
→ #13285 |
What
Cherry-picked from MisskeyIO#441
Cherry-picked from MisskeyIO#438
Why
すでにmetaに存在するrepositoryUrlとfeedbackUrlを活用できるように
Additional info (optional)
Checklist